ioos / system-test

IOOS DMAC System Integration Test project
github.com/ioos/system-test/wiki
The Unlicense
7 stars 14 forks source link

Tidy up Scenario 2A Waves model obs notebook #178

Closed birdage closed 9 years ago

birdage commented 10 years ago

in the model obs waves notebook there are a number of red warning sections taking up a large amount of room in the notebook. i dont think we should remove all the error text content but i would like to see a simplified error message, i.e error with <DATASET/URL>. Also it looks like one dataset can throw multiple error messages, lets reduce it to one error message. Ive assigned this to @Bobfrat, he will do the review once the pull request is made, @benjwadams if you could make the changes.

http://nbviewer.ipython.org/github/ioos/system-test/blob/master/Theme_2_Extreme_Events/Scenario_2A/ModelDataCompare_Waves/Model_Obs_Compare_Waves.ipynb

ocefpaf commented 10 years ago

@Bobfrat If the goal is to keep the notebook clean you might want to consider the logging module instead of adding another layer to the warnings. Here is an example:

http://nbviewer.ipython.org/github/ioos/secoora/blob/master/notebooks/inundation/inundation_secoora.ipynb

PS: You might not want to change all the print() to log(), maybe all you want to do is,

log.captureWarnings(True)
jkupiec commented 9 years ago

Without any more comments, I am closing this issue.