Update temp notebook - Githubissues

ioos / system-test

IOOS DMAC System Integration Test project

github.com/ioos/system-test/wiki

The Unlicense

7 stars 14 forks source link

Update temp notebook #182

Closed Bobfrat closed 9 years ago

Bobfrat commented 9 years ago

USEAST model is working

ocefpaf commented 9 years ago

Some review notes that I cannot add inline:

https://github.com/Bobfrat/system-test/blob/temp_nb/Theme_1_Baseline/Scenario_1F_Temperature/Temperature.py#L64 (typo)
'HTML' imported but unused
'itemgetter' imported but unused
'get_station_longName' imported but unused

A quick look at both conda-requirements.txt and pip-requirements.txt shows that folium is missing (since you are using @birdage wms branch, that should be there.) I will perform a more through review on both files later.

Bobfrat commented 9 years ago

Thanks @ocefpaf I will take a look tomorrow at fixing these.

Bobfrat commented 9 years ago

@ocefpaf, I incorporated your suggestions. For folium I had to pip install from @birdage branch so I put that in the README.

ocefpaf commented 9 years ago

Merged! Thanks @Bobfrat.

birdage commented 9 years ago

@Bobfrat @ocefpaf i think my changes were pulled in to the master of folium so we could use that in future.

ocefpaf commented 9 years ago

Yes, you are right, even the WMS layer feature is there now. My bad. (And I was the one that pushed that to folium! What a memory!!)

Bobfrat commented 9 years ago

I saw that but it's not on PyPI yet so you cant just simply pip install folium. I point to your branch instead of folium's master in case you make some improvements.

ocefpaf commented 9 years ago

We also have to fix folium in @rsignell-usgs conda-recipes repository. The recipe still points to my outdated branch. I will make some test here and send a PR to that repository to fix that.