ioos / system-test

IOOS DMAC System Integration Test project
github.com/ioos/system-test/wiki
The Unlicense
7 stars 14 forks source link

Improve/create HFR example #230

Open ocefpaf opened 8 years ago

jbosch-noaa commented 8 years ago

Maybe we can start with the code here: https://ioos.github.io/system-test/blog/2015/10/26/HF_Radar_Currents_west_coast/

ocefpaf commented 8 years ago

:+1: I believe that is the best option.

We need to define the focus of the example:

emiliom commented 8 years ago

Going through the HFR notebook, I noticed that there are pyoos statements/cells that are not actually ever used. The COOPS (cell 9) and NDBC (cell 12) sos collectors are setup but never used. The subsequent cells (cells 10 & 13) just skip to making direct, semi hard-wired SOS GetObservation GET requests by constructing the long url's.

ocefpaf commented 8 years ago

Going through the HFR notebook, I noticed that there are pyoos statements/cells that are not actually ever used.

I try to clean the original notebook as much as I can, but they were to big and undocumented that I always miss something behind. I will update it to remove the unused code. Thanks @emiliom!

ocefpaf commented 8 years ago

The subsequent cells (cells 10 & 13) just skip to making direct, semi hard-wired SOS GetObservation GET requests by constructing the long url's.

BTW that is something we should avoid!