ioos / system-test

IOOS DMAC System Integration Test project
github.com/ioos/system-test/wiki
The Unlicense
7 stars 14 forks source link

Three Sample notebooks for Baseline. #92

Closed hdean83 closed 10 years ago

hdean83 commented 10 years ago

These are very basic attempts at testing the availability of records using ontologies and IOOS Core variable terms, model indicator strings, and agency strings.

rsignell-usgs commented 10 years ago

I assigned myself to review.

rsignell-usgs commented 10 years ago

@hdean83 , three issues I see:

  1. the README.md file looks incorrect. This is what is should look like: https://github.com/ioos/system-test/blob/master/Theme_3_Species_Protection_and_Marine_Habitat_Conservation/Scenario_3A_Assessing_Seabird_Vulnerability_in_the_Bering_Sea/Scenario_3A_Important_Bird_Area_Polygon_Analysis/README.md
  2. There should also be a pip-requirements.txt file, like this one: https://github.com/ioos/system-test/blob/master/Theme_3_Species_Protection_and_Marine_Habitat_Conservation/Scenario_3A_Assessing_Seabird_Vulnerability_in_the_Bering_Sea/Scenario_3A_Important_Bird_Area_Polygon_Analysis/pip-requirements.txt
  3. There are no .py files to accompany the .ipynb files.
rsignell-usgs commented 10 years ago

@hdean83 , are you working on this?

hdean83 commented 10 years ago

Yes. I committed the updated files as you requested but was not sure whether they were automatically updated via the existing pull request... I made a bit of a mess of branches so I may start over this weekend and do a new pull request.

Sent from my iPhone

On Jun 13, 2014, at 4:36 PM, Rich Signell notifications@github.com wrote:

@hdean83 , are you working on this?

— Reply to this email directly or view it on GitHub.

ocefpaf commented 10 years ago

@hdean83, yes, they are automatically updated. We can see your new commits using github's web interface. If you can, I recommend to continue working on this PR instead of opening a new one.

rsignell-usgs commented 10 years ago

I'm reviewing it right now.

rsignell-usgs commented 10 years ago

Fixes #98