search

iop-alliance / okh-search

A self-hostable, federated search for open source hardware
https://search.openknowhow.org
MIT License
10 stars 9 forks source link

How to deal with manifests in unresolved pull requests #17

Open jbon opened 4 years ago

jbon commented 4 years ago

I added to the list the following manifests André created: https://github.com/brianchowlab/OSP/pull/5 https://github.com/BioDesignRealWorld/Fermento/pull/1 https://github.com/HoldenLab/microscope-incubation-box/pull/1 https://github.com/vektorious/lightM/pull/9 https://github.com/vektorious/test_tube_photometer/pull/1

They have all be created as part of a pull request and the hardware authors did not accept the pull request.

Do we want to process these kinds of manifests differently? if yes how? Should we try to keep track of whether they will be integrated in the source repo at some point?

jbon commented 4 years ago

The last one I added is tricky because I created the pull request directly on the GitHub webapp and it created a patch-1 branch that will disappear when the pull request will be accepted. Won't it?

https://raw.githubusercontent.com/jbon/OttoDIY/patch-1/okh-OttoDIY.yml

julianstirling commented 4 years ago

It is on your fork of his repository so other people won't delete your fork. If you merge your patch branch into your fork's master and then point okh at that then it should be permanent. At some point it would be good to update okh. This is the big worry or OKH for me if we set up a crawler: If multiple copies of the same manifest get found how do we de-duplicate them effectively?

kasbah commented 4 years ago

As for just this list, I don't think we should be adding forks to the list. I suggest we wait till people merge the manifests in, thus taking ownership and giving consent to be listed somewhere like this search.