iopietro / Travianz-Legacy

Join our Discord Server: https://discordapp.com/invite/9fbJKP9 | New repo: https://github.com/iopietro/Travianz
GNU General Public License v3.0
160 stars 95 forks source link

When giving to someone multihunter access they are unable to receive messages written to Multihunter #398

Closed RevertIT closed 6 years ago

RevertIT commented 6 years ago

So the thing is multihunter on this Travian version can only ban and nothing else, not even receive messages players send to multihunter. Can that be fixed?

velhbxtyrj commented 6 years ago

hmm. I just gave Multihunter rights to another user. All messages are sent and read as expected.

RevertIT commented 6 years ago

You don't understand. When you give access to someone, and when you send a message to Multihunter name, someone with mh privileges didnt receive that message. All mhs should receive messages sent to multihunter username

velhbxtyrj commented 6 years ago

Yes, I did not understand it.

If you look closely at how this is now, then in fact, a user with access rights of a multihunter is an admin, which should not be. In essence, a multihunter should have rights only to view logs, bans and something else like that, but not a change in server settings, and especially its resetting. As for me, it's not worth doing all the multihunter received a letter. There may be confusion in finding out a particular problem. Multihunter is needed to see whether everything goes according to the rules. And in case of violation, give a ban or punish.

RevertIT commented 6 years ago

Plus that multihunter doesnt have almost any permission and it sucks at the moment. I have 3 mhs and they complain about having no rights at all.

velhbxtyrj commented 6 years ago

Oops. I apologize. I accidentally logged in under the admin. Such a multihunter does not have any rights at all. But he has what I was talking about. At the moment, the multihunter has access to: Ban User, User Login Log, User Illegal Log, Punish Player, Server info, Online users, Search, IGM/Reports.

As for me, this for the multihunter is enough. Since I already said that this access is just for observation. And to send out to all such multihunter the same message from the player is not worth it. To avoid confusion.

It's my opinion :) And I do not insist on this :Р

edit: The only thing that does not work from the section "Punish Player" is to Delete Troops.

martinambrus commented 6 years ago

Multihunter should be a group of people, not a single person - if a server gets popular, it's too much for a single person to handle. As for messaging, I see this working very similar to how Support works. There is only one support person but there is an option in system settings for admins to allow sending and receiving support messages. This is so if I'm an admin and playing the game as myself, then I should not be forced to log out, log in as Support, check and answer messages, then resume playing my account. Multihunter people should share the same principle - they would see all MH messages, have the ability to reply to all of them. They will see which ones are read and which ones are not, so there should not be much confusion with double-answering and so on. But I do get what @velhbxtyrj says - it could be confusing to follow individual threads by individual people.

As for access rights, I think the only thing missing is access to villages. I've just committed an update that allows MH to access that. I don't think changing anything for users or village should be permissible by a MH, as they are more of a detectives rather than admins.

Any more thoughts?

RevertIT commented 6 years ago

Maybe adding admin and owner rank separately. Owner has server settings and server resetting access. Admin does not. Would be pretty reasonable and i hope that we will get option to see all messages as mh sent to mh. Because having 3 people as mh and that they are not getting a sinle message, only a mh account and admins is unfair.

velhbxtyrj commented 6 years ago

If we follow the path that one letter will be sent completely to all the mh, then it would be nice if the letters were sent by secondary multihunter alternately. The first letter to the first mh, the second to the second, the third to the third, and so on in a circle. So one letter would go to one person. Well, of course, in order for the Chief Multihunter to see all this, all the letters should come to him.

RevertIT commented 6 years ago

No need for that. Only let a mh assing a specific reply aka ticket so other mhs doesnt have to reply to same person twice.

martinambrus commented 6 years ago

OK, there's a lot of potential to improve messaging and access rights in general. Your suggestions are noted but it would probably be best to open separate issues for those, since changing the messaging system completely (as @velhbxtyrj suggests - with alternation and a Chief Multihunter) or separating Admin + Owner ranks (@phaze1G ) is not quite what this issue is about.

As I said before, new features (apart from the 3 existing ones in Legacy project) will not be added to the legacy code anymore. They will have to wait until the refactored code is around.

Thank you for your inspiring comments guys and if you can move them to separate issues, I can look into implementing them during code refactoring :)

Right now, I think I'll go with simple support-like system (messaging-wise) for MHs and had already added enough permissions to MHs for them to be able to do their job.

velhbxtyrj commented 6 years ago

This must be approached correctly. I thought that the alternation is not exactly what need. If the person will be absent and letters will come to him it will be a problem :)

martinambrus commented 6 years ago

Implemented in similar fashion as Support works. Multihunter ranked players can see and send messages sent to the actual Multihunter account. Please test and report if this functionality works for you :) Thanks!

image

RevertIT commented 6 years ago

Working as intended. Just other mhs don't have an orange inbox color to indicate that messages arrived, they can check only when they open a mailbox that they have a new mailbox sent to MH.

martinambrus commented 6 years ago

Fixed :)