search

iopietro / Travianz-Legacy

Join our Discord Server: https://discordapp.com/invite/9fbJKP9 | New repo: https://github.com/iopietro/Travianz
GNU General Public License v3.0
160 stars 95 forks source link

In Troop Movements set the graphics correctly #429

Closed agony09 closed 6 years ago

agony09 commented 6 years ago

in dorf1.php the "Troop Movements:" is displayed. I noticed that there the graphic is not displayed in a same line. Would it be possible to correct that? Here are some examples:

Your demo site: troop_falsch (The icon shown always hangs over the arrows.)

from Travian page: troop_richtig

(2 examples. Everything is always in the same line.)

martinambrus commented 6 years ago

should be fixed now :P

velhbxtyrj commented 6 years ago

Not completely centered. Need either a picture a little higher or Either the text is slightly lower.

In the editor, I put 1px in this line and everything is perfectly centered. But changing this in the css file does not happen. Maybe I'm changing this is not in that file?

https://github.com/Shadowss/TravianZ/blob/f5c8b858d9a3c11198bc3723a988800c423595ee/gpack/travian_default/lang/en/compact.css#L3464

martinambrus commented 6 years ago

I've not really played with the arrow's vertical position - I know it's not centered vertically but this issue is still fixed, so I'll be closing this one for now

I can't be perfecting stuff in the legacy code anymore, since the aim of the legacy code fixing is not to make everything perfect but rather make it playable, otherwise I'd be doing these small fixed indefinitely

velhbxtyrj commented 6 years ago

The fact is that I already played with this and pointed out the line in which to change the value :) but after I write this in the css file, nothing happens. In the editor, Google Chrome displays all the same 3px, although I saved 1px in the specified file.

1 2

martinambrus commented 6 years ago

@velhbxtyrj you can always create a pull request with your fix for this, of course, even though this issue is now closed