Fixed some bugs

[iopietro]

Fixed the issue #446.

The hero experience was distributed incorrectly if the defender(s)/attacker had created more than 1 hero. Now, only the attacking hero/defending heroes will receive the experience (even if deads).

Added two controls to prevent the execution of some instructions (for catas and rams) if the attacked target is an oasis. (If you want to see what i've changed, you should click on "Split" instead of using "Unified", because GitHub shows it "incorrectly").

[eliopinho]

please keep doing your work, we all apreciate.. at this rate you will fix all bugs shortly :)

[eliopinho]

by the way @iopietro i think catapults are able to damage the wall if i remember correctly only rams can do that.. (if not, as no need to train rams)

and also when a attack occurs with no damage shows in the report (damage from level XX to NAN) can you change to (damage from level XX to NONE) this helps in no experienced players to understant whats going..

the market place wont show in avaliable soon buildings somethimes. to the player see pre requesits needs to go to instructions

and finally in the last server i played the reports of users that release troops from the gaullic trappers has shows to other players sometimes

[iopietro]

[1] I think it's a bug, catas shouldn't be able to damage walls. [2] I think it's another bug, if catas don't damage anything in the village, the report should show "XX was not damaged". [4] It could be caused because some variables aren't unsetted and multiple players have attacked in the same second.

I'll certainly look into these bugs.

[eliopinho]

i tested infinit amount of resources from oasis, i think thats the same.. i set the server to 10x speed if the warehouses are full and you raid multiple times always raid big amounts...

after work i will test it again, sure if i do nothing wrong.

[iopietro]

That exploit is fixed, you can't gain an infinite amount of resources anymore. If you attack a conquered oasis, you'll gain 10% of resources of the owner's village and these resources will be removed from that village.

For example: if you attack your own oasis with 200k of every resources in the village, you'll gain 20k of every resources from the battle, but after the attack you'll village will have 180k of every resources. So, your tropps will return with 20k of every resources for a total of 200k (180k in the village + 20k of loot, before the fix, the total amount of resources would have been 220k).

[eliopinho]

all done!

[iopietro]

@eliopinho

1) Fixed in the latest pull request. 2) I don't know how to reproduce that bug, do you have some reports of it? 3) Fixed. 4) It should be fixed.

[eliopinho]

To reproduce Damage from level xx to NAN
This happen when attacking romans capital with the stonesman on it.. Since the buildings are 300% stronger With for example 50 catapults..

Tomorrow i try reproduce and send the report.. In Portugal now are 2am i gona sleep :)

[iopietro]

@eliopinho, Ok, i reproduced it, it happens because it does the square root of a negative number, resulting in a not-Real number (complex number), it shows "NAN" because it's not a valid number.

[iopietro]

I have fixed the second bug with the latest 2 commits.