search

iopietro / Travianz-Legacy

Join our Discord Server: https://discordapp.com/invite/9fbJKP9 | New repo: https://github.com/iopietro/Travianz
GNU General Public License v3.0
160 stars 95 forks source link

New mechanics and functions for TravianC (Travian Crazy) and refactoring #524

Open velhbxtyrj opened 6 years ago

velhbxtyrj commented 6 years ago
velhbxtyrj commented 6 years ago

@iopietro @Shadowss In this issue I collected everything that was labeled by the label "enhancement". Some problems are duplicated with the previous open problem of bugs. Something like this :)

P.S. I think it will be easier to see all that is open at the moment in all issue.

iopietro commented 6 years ago

Nice, great job :)!

velhbxtyrj commented 6 years ago

@iopietro Pay attention to this issue #402. I guess that it is already implemented?

iopietro commented 6 years ago

Yes, i already fixed it in a previous commit, i forgot to mark it as closed.

eliopinho commented 6 years ago

well this is a good prespective.

but i think in my opinion this "travianC" must be an option in the install, like travian official quest vs travianZ quest.

also i think in first rule must be fix all "oficcial" game bugs and associate all translations to one file, for the other people like me for example, can translate the whole game into native languages and add here to be included in this version.

after the whole oficial game was tested and bugless keep working on that extra functions leaving to admin the choice off active them or not..

the big percentage off players here only want put the oficial game working fully and play with friends on a small server..

this only my opinion :) thanks to all people working here , in special @iopietro for new blood and doing most weight work

velhbxtyrj commented 6 years ago

@eliopinho As far as I understand it correctly, it will be an ordinary TravianZ with the ability to include one or another function that will expand the possibility of the usual version) From the box this script should come with the functionality of the usual T3.6 travian.

@iopietro @Shadowss Some things like here and in another similar issue with bugs have both things that extend functionality and that relate directly to the usual version of T3.6. I propose to review these two issue and the gap in the separate things that complement the functionality and should be included separately and the things that are bugs.

P.S. I hope that Google correctly translated what I wanted to express in my thoughts :)

iopietro commented 6 years ago

@eliopinho @velhbxtyrj, Yeah, I agree, new functions should be separated from bug fixing, that's why I'll first try to fix all bugs of this version and then start to add new functionality to the game (and the admin of the server will be able to choose what functionality activate and what not).

Current "road map": 1) Fixing all bugs of this version. 2) Completely refactoring the game with OOP and maybe MVVM (MVC) and optimizing the code/queries. 3) Adding new functionality to the game.

velhbxtyrj commented 6 years ago

So I'll do it today. Then we will have the information even clearer.

iopietro commented 6 years ago

Thanks :).

velhbxtyrj commented 6 years ago

I just do not remember about the vacation mode. Was it implemented in T4+? Transfer it to refactor or leave it in bugs?

iopietro commented 6 years ago

If i remember correctly, it wansn't in the T3.6 version, they introduced it in the T4.2/T4.4, you can transfer it.

velhbxtyrj commented 6 years ago

I hope that I transferred everything to the places where it should be.

Shadowss commented 6 years ago

Peace system picture message :

https://user-images.githubusercontent.com/5437151/38741765-96f7a462-3f32-11e8-90ee-20149b1ae3f4.jpg

Artifact system picture message :

https://user-images.githubusercontent.com/5437151/38771387-5c1b3884-401a-11e8-95f2-06599cc08b14.jpg

velhbxtyrj commented 6 years ago

@iopietro @Shadowss I delete some of the items here, since they are duplicated in another issue and refer to bugs:

  • [x] On village name , you must leave players to put special chars like : 00. KILLUϺINA†I (i mean : , . †)
  • [ ] Add oases to select (50 , 100 or 150%) in crop_finder.php
  • [x] Also this is a good map to add in Admin Panel FOR THE ARTEFACTS DISTRIBUTION , like already exist map in Admin Panel b4629f56bf5b0a48c18eb23a69ebd6fb
iopietro commented 6 years ago

You did well :).

velhbxtyrj commented 6 years ago

@iopietro ~I tried to make the activation and deactivation of oases in the profile of the player using the admin and during the installation. During installation, everything works fine. Recording is off. Going to the admin area, I can only turn on (after saving, the entry is deleted from the config file). It can not be turned off (writing to the file is not specified at all). I've been trying to break it down for a few hours and still have not. Could you see what's wrong with me? Here are all the files:~

On the newly installed server, everything works fine. Everything turns on and off. Why can not this be done on the old server? And still, I ask you, if you have free time, to view these files for errors.

Display oasis in profile.zip

default 1 2 3

iopietro commented 6 years ago

I think that because old servers don't have it written in the settings, I'll look carefully those errors.

velhbxtyrj commented 6 years ago

But I independently registered this parameter in the config. And after I tried to change it, this record just went away and in the game it's always on. Even if it's disabled in the config, and change any other partition, then the entry is also deleted and becomes always on.

I also noticed that if we have an old server, then for this to work it is necessary for us to add the record by ourselves on this path and everything will work as expected (file is called constant_format.tpl): https://github.com/Shadowss/TravianZ/tree/master/GameEngine/Admin/Mods

In this code, the file is now missing constant_format.tpl. But when the server is installed then this file is available on the server and when I registered the same entry in it as in this file https://github.com/Shadowss/TravianZ/blob/master/install/data/constant_format.tpl everything started working as and expected.

It can be what that error that record there did not get automatically during configuration of settings? Or is it necessary to write to this file yourself for the code to work on the old server?

iopietro commented 6 years ago

I do think so, constant_format and all files of the admin panels that edit config.php should be edited.

velhbxtyrj commented 6 years ago

So it turns out that I did everything right. Today, I edited the files a little bit more that would eliminate fatal errors while editing other configuration sections. Can it make sense to try to unite these files here?

And one more thing about this. I created the second profile file (old file overview.tpl and new file newOverview.tpl). What is the best solution in this case? Leave one file and in it to do a conclusion of the different information or it will be better two different files?

iopietro commented 6 years ago

Yep, it makes sense, it can be optimized by merging those single files in a unique one.

It would be better leaving only one file with an "if" that decides (by confronting the constant in the config.php file) if oases should be showed or not.

velhbxtyrj commented 6 years ago

@iopietro I found three commits (more precisely I hope that it is those commits that changed the logic of the alliance): https://github.com/Shadowss/TravianZ/commit/5d91de0e14b640f3dfa929cfc62ba729fcfd3224#diff-f43cd9959fc7f6c0f8e1e43a8b034792 https://github.com/Shadowss/TravianZ/commit/c9038e20b873e776e27dee05f2974b46d98eee09#diff-f43cd9959fc7f6c0f8e1e43a8b034792 https://github.com/Shadowss/TravianZ/commit/8a3591a8b0cb2a62c6782bdad246f9c81d0d0939#diff-f43cd9959fc7f6c0f8e1e43a8b034792 where the logic of the alliance was changed https://github.com/Shadowss/TravianZ/wiki/New-Alliance-&-Embassy-Mechanics

But for me it's a little incomprehensible that I would make a division into old code and a new code to enable and disable as a new function.

I could take the old code and add it to the if else: if() { new code } else { old code }

but it seems to me that this will be wrong and can cause some errors that could be corrected or something else.

iopietro commented 6 years ago

For now, I removed it in the refactored version, but it'll be rewritten from scratch later.