iopietro / Travianz-Legacy

Join our Discord Server: https://discordapp.com/invite/9fbJKP9 | New repo: https://github.com/iopietro/Travianz
GNU General Public License v3.0
160 stars 94 forks source link

offers market [N4RR4] #527

Closed narrita closed 6 years ago

narrita commented 6 years ago
  1. expected behaviour you can not bid resources without entering values

  2. incorrect behaviour offers 1 type of resource without introducing values and shows you that the merchant says 0, when you cancel it gives you resources and so you can fill the stores whenever you want

  3. the operating system & version win7 , debian server

  4. PHP version on the server any kind of version

  5. MySQL / MariaDB version on the server any kind of version

velhbxtyrj commented 6 years ago

@narrita Do you have the latest code? If I understood correctly then this should be corrected here https://github.com/Shadowss/TravianZ/commit/e116511c738730f6479b7fc28f6535ebfc219a54.

narrita commented 6 years ago

i use https://github.com/Shadowss/TravianZ

but at http://travian.shadowss.ro/login.php there is no such this error

I going to download the version again and try again

I need some help from you because the game shows high indexes of calculate ms

velhbxtyrj commented 6 years ago

If you downloaded the code more than 5 days ago there was still this error. On this site http://travian.shadowss.ro the code is updated today so there is no such error.

narrita commented 6 years ago

@velhbxtyrj Parse error: syntax error, unexpected '[' in Travian\GameEngine\Market.php on line 256

velhbxtyrj commented 6 years ago

Most likely not all files have been replaced as needed. Did you dump all the files on the hosting with a replacement?

Try again with all the files completely replaced.

narrita commented 6 years ago

I install the new travianz in its entirety do not replace files or restore saves. It was new installation using:

xampp-win32-5.6.34-0-VC11 PHP / 5.6.34 win7 64bits

please be calm with me I've been in this for several weeks

velhbxtyrj commented 6 years ago

Yes you are right. I used php 7.0 so there was no such error. At php 5.6 it is available.

velhbxtyrj commented 6 years ago

@iopietro please pay attention to this.

Parse error: syntax error, unexpected '[' in /home/u997437127/public_html/GameEngine/Market.php on line 256

This error only occurs on php 5.6

iopietro commented 6 years ago

Damn, apparently ([$var1, $var2, $var3])[$index] can't be done in PHP 5.6

narrita commented 6 years ago

ok them install php 7 :)

if you want several friends of mine from Cuba we are in to https://discord.gg/BXm2TV enter so we can talk better

eliopinho commented 6 years ago

@iopietro we all should use recent php on servers, no old ones.. theres no need to backport to older versions :)

iopietro commented 6 years ago

Yeah, I only need to see if free hostings supports PHP 7.

iopietro commented 6 years ago

@narrita, You gave me an idea, we should create a TravianZ Discord server!

velhbxtyrj commented 6 years ago

@iopietro If I understand correctly, then pshp 5.6 will cease to be supported after 8 months? http://php.net/supported-versions.php

iopietro commented 6 years ago

Yes, it's correct, that's why we shouldn't support PHP 5.6 anymore.

velhbxtyrj commented 6 years ago

Then it may make sense to change the entry in README.md with PHP 5.6.32+ on PHP 7.0+

iopietro commented 6 years ago

Yep, I've seen that about 80/90% of free hostings support PHP 7.0+, so I'll change the readme.

velhbxtyrj commented 6 years ago

I myself use free hosting on php 7.0 ))

narrita commented 6 years ago

@iopietro @velhbxtyrj

The market error still works offers the exact amount that 1 merchant carries after you offer 1 x 2 exactly and when you cancel that offer it gives you the amount of resources you bid in the 1st offer example so that they understand me

1st offer 1500 clay x 1500 wood 2nd offer 1 of clay x 2 of wood

when you cancel the 2nd offer you receive 1500 clay instead of 1 clay.

regards

iopietro commented 6 years ago

That's a different (and pretty huge) bug, I'll look into it.

iopietro commented 6 years ago

Fixed in e9def19bd95d8fb6b6726585892b9d8c8f1098b3.

Dayran commented 6 years ago

@narrita que tal