search

iopipe / iopipe-js-core

Observe and develop serverless apps with confidence on AWS Lambda with Tracing, Metrics, Profiling, Monitoring, and more.
https://www.iopipe.com/
Apache License 2.0
124 stars 20 forks source link

Separating succeed and callback for promises #341

Closed mrickard closed 5 years ago

mrickard commented 5 years ago

Separating context.succeed and callback calls into separate .thenables on the agent's promise-handling callback. Checking if this reduces or eliminates the intermittent timing error on previous CircleCI builds.

mrickard commented 5 years ago

My initial PR passed CircleCI tests, and then a re-run of the tests failed, so that rules this out as the solution for the timeout. (That said, I prefer separating these steps this way for clarity, but if it's not making a detectable difference, it's not worth releasing on its own.)