search

iopipe / iopipe-js-profiler

Profiling and tracing for AWS Lambda
https://www.iopipe.com
Apache License 2.0
11 stars 7 forks source link

Heap snapshots #31

Closed ewindisch closed 6 years ago

ewindisch commented 6 years ago

Adds heap snapshotting. Uploads to the signed URL are now zip files (this requires a synchronized change to manage these files on the signing API!)

Signed-off-by: Erica Windisch erica@iopipe.com

ewindisch commented 6 years ago

Please review. Needs changes in upstream API before release.

@pselle @coreylight

coreylight commented 6 years ago

Looking better @ewindisch! I'd like to see tests of the core functionality, probably utilizing the mock functionality that you started on with takeSnapshot

ewindisch commented 6 years ago

@coreylight more tests would be fantastic but seem to be outside the scope of this change. This adds tests to new functionality that are on par with existing tests. Expanded tests would be fantastic, but maybe as a future improvement?

ewindisch commented 6 years ago

This issue was blocked on changes to the signing API which have been completed. It has been updated to support file extensions. I'd love review! @kolanos

coreylight commented 6 years ago

Thanks @ewindisch, this is going to be awesome.