iopipe / iopipe-js-profiler

Profiling and tracing for AWS Lambda
https://www.iopipe.com
Apache License 2.0
11 stars 7 forks source link

Indicate if profiling upload failed #34

Open coreylight opened 6 years ago

coreylight commented 6 years ago

At times getting the error: "Download profiling data => "The specified key does not exist."" https://iopipe.slack.com/archives/C6Q4HSLKD/p1518276447000024

Profiler should indicate if upload failed, so that there are no file misses.

ewindisch commented 6 years ago

The upload may fail for an object but our API does not know this as it bases the presence of profiling data based on if the plugin is enabled or not.

Two solutions are apparent to me:

I do not like the first solution as it does not allow us to detect failures, it would only remove visibility of the existence of an error.

With moving to using JWTs for uploading profile links, we can simply not include the JWT link if we know the upload to have failed. Consuming applications would have to be aware of this behavior and provide clean messages/warnings/errors around enabled profilers without uploads.