search

iopipe / serverless-plugin-iopipe

Automatically wrap your serverless framework functions with IOpipe
https://www.iopipe.com
Apache License 2.0
40 stars 8 forks source link

SLS invoke local not working with Serverless Framework versions > 1.32.0 #94

Closed adjohn closed 5 years ago

adjohn commented 5 years ago

There seems to be a regression with the latest versions of the serverless framework when using sls invoke local and IOpipe. There are no errors, but the telemetry is not sent to IOpipe when running invoke local.

The workaround is to downgrade serverless framework to version 1.32.0

ewindisch commented 5 years ago

@mrickard this is affecting at least one user contacting support! Thanks!

ewindisch commented 5 years ago

@mrickard was this resolved with the commit to unpin the sls framework version?

mrickard commented 5 years ago

@ewindisch I think so: the two likely culprits were 1) a regression in recent versions of the module (as identified by @adjohn) 2) a default assignment of "id" to the awsRequestId for locally invoked events (as identified by @kolanos)

I pinned the version and assigned a UUID to the request IDs for locally invoked functions, so these two potential causes for non-logging functions were addressed in the merge.

ewindisch commented 5 years ago

Great if/as this is confirmed we should close the issue! Thanks. I'll communicate to the user I was speaking with and have them upgrade.

mrickard commented 5 years ago

Excellent. In my tests I'm getting both local and AWS invocations in a dashboard.