Update to SDL 2.24.0 - Githubissues

zturtleman commented 2 years ago

Update MinGW and macOS Universal 2 (x86_64, arm64) SDL libraries from 2.0.16 to 2.24.0.

Update macOS Universal 1 (ppc, x86, x86_64) SDL library from 2.0.16 to SDL 2.0.22. (ppc still has SDL 2.0.1.)

There is now three copies of SDL headers; 2.0.1 (with changes for ppc), 2.0.22, and 2.24.0.

There is now a separate SDL dylib for macOS Universal Binary 1 and 2. Xcode 13.3 fails to compile if ppc is in the SDL dylib (per #563). SDL 2.24.0 dropped support for macOS 10.6 (which is last to support x86). SDL documentation says SDL 2.24.0 also dropped macOS 10.7 and 10.8. So Universal 2 is now 10.9 or later while 10.5 to 10.8 live in Universal 1.

Fixes #527, #528, #529, #563, #566, and macOS 10.6 (<10.10?) crashing when scrolling MacBook Pro touchpad (https://github.com/libsdl-org/SDL/pull/4961).

SDL compiled on Linux using mingw-w64 and osxcross. Tested compiling and running on macOS 10.6 and 10.11. Windows builds tested with Wine.

Issues (not a deal breaker imo):

Fixed: MSVC .lib files are now updated: ~~Visual Studio (MSVC) .lib files haven't been updated. SDL264.lib needs to be compiled with SDL264.dll name. (The existing 2.0.16 .lib files presumably still work until ioq3 uses SDL 2.0.18+ APIs.)~~
Xcode project hasn't been updated. Need to change SDL dylib path to code/libs/macosx-ub2.
I haven't tested it on macOS ARM64.

@tomkidd if you have time, could you check Xcode/ARM64 and if signing/notarizing still works?

tomkidd commented 2 years ago

Yes I can take a look, and thanks for doing this. I had started working on a similar fix for the UB/UB2 issue and then life got in the way and I haven't had the bandwidth to look at it since, but I'll check out the arm64 bits.

Fun fact: making sure the old version could still build on Snow Leopard was what I was doing when my old Mac mini died

https://twitter.com/macsourceports/status/1549876888360964097

zturtleman commented 2 years ago

Ah, it's unfortunate your old Mac mini died.

I updated Visual Studio (MSVC) .lib files for SDL 2.24.0. My build scripts for SDL 2.

futurepr0n commented 2 years ago

Just wanted to leave comment that checking out this pull request and building was able to fix my mac libsdl2 issues #566 ! If you could please merge this into the master so that everyone can benefit and so it can be cleanly built on the mac that would be fantastic!

ioquake / ioq3

Update to SDL 2.24.0 #573