ioquake / ioq3

The ioquake3 community effort to continue supporting/developing id's Quake III Arena
https://www.ioquake3.org/
GNU General Public License v2.0
2.34k stars 522 forks source link

options shows wrong resolution for custom resolution #623

Open MyTDT-Mysoft opened 7 months ago

MyTDT-Mysoft commented 7 months ago

ok... so this is a bug even with the original quake 3 engine... that is still present there... when using R_MODE -1 ... and then you go to the options it shows 640x480 and if you change any options it will then revert back to that... shouldnt that be fixed for once?

Calinou commented 7 months ago

I'd propose getting rid of the UI resolution setting entirely, now that r_mode -2 (desktop resolution) is the default. There could be fields to specify a custom r_mode -1 resolution, with a boolean value that determines whether desktop resolution is used (or this custom resolution instead). I've only ever used r_mode -1 and -2 :slightly_smiling_face:

That said, mods would bring back the old mode-based resolution selection anyway, causing this issue to appear again unless ioquake3 decides to ignore r_mode values greater than or equal to 0.

zturtleman commented 7 months ago

This is fixed in Quake 3 https://github.com/ioquake/ioq3/commit/c61417b8e2e453e14e5a0d012910df5062186f2e and Team Arena https://github.com/ioquake/ioq3/commit/9fcb2bb336583d998cc886ecf7e37ea2278b6b78 but only if the ioquake3 "mod" ui.qvm is used.