Fix issue with 'declare -x' environment variables

ioquatix / script-runner

This package will run various script files inside of Atom. It currently supports JavaScript, CoffeeScript, Ruby, and Python. You can add more.

http://atom.io/packages/script-runner

Other

62 stars 23 forks source link

Fix issue with 'declare -x' environment variables #35

Closed digitalabacus closed 7 years ago

digitalabacus commented 9 years ago

Bash environment variables can be in the form « declare -x NAME="VALUE" ». This patch fixes that issue by stripping the "declare -x" prefix, stripping the surrounding quotes from the value, and replacing double backslashes with single backslashes in the value.

huba commented 9 years ago

I'm not entirely certain what the PR is doing, there are only changes in one of the example scripts. We have actually made a separate package to deal with the environment extraction. https://github.com/ioquatix/shell-environment

ioquatix commented 9 years ago

@brianmoquin can you please review https://github.com/ioquatix/shell-environment and see if this patch is still relevant? We fixed a bunch of issues relating to this already. Thanks for your contribution.

ioquatix commented 7 years ago

@digitalabacus can you please review this and let me know if this still needs work.