Closed huba closed 7 years ago
I think it's good idea to use pty.js in any case the python script wrapper was a hack to make things work can you merge this once you are happy with it
I've added a few comments. The main one would be running scripts which aren't saved.
If you have time it could be great to try and finish this off.
How about saving it wherever os.tmpdir
points then blowing it away after it has finished running? For now anyway...
With this we would of course have to avoid using editor.savebuffer
(or whatever) to stop the editor from recognising that the buffer is an actual file on disk.
@huba Thanks for all your hard work on this and discussing the ideas. 2.0.0 is now released, and this PR has been largely integrated in one way or another.
We do however lose the ability to pipe unsaved buffers into the stdin of the interpreter, to deal with that I added a save dialog that automatically pops up if the run event is triggered on an unsaved buffer.
Also we no longer need the python script to wrap the pty.