Closed seanodell closed 7 years ago
OMG LOL.. I am the developer and I did all the new update work on my Linux box.... and now I try to install on my MBP and script-runner fails to install because of pty.js
Uh, I guess I'm gonna try to fix this... why pty.js so difficult.. oh because it uses gyp which rhymes with shit.
This should be fixed in v2.1.0 which I just released. Can you please try the update and re-open this issue if it's still a problem.
I can't reopen once a contributor closes. :( I got the same issue after upgrading to v2.1.0, and it sent me right back here saying it had already been reported.
If you run python --version
what is the output?
I also just realised this might be an issue with your shell.
what is your default shell for your user?
Bash ... MacOS default.
Hmm, that's odd. It's failing because it can't load your shell environment. What is the output of bash -ilc env
Can you let me know if this is still an issue?
It seems to be fixed now, but I've been using https://github.com/rgbkrk/atom-script and prefer that, actually.
Awesome, yeah I used to use atom-script
too. What do you prefer about it?
It works really well, covers a lot of languages and I like where the output goes. It makes sense to me. When I ran script-runner just now, I got this new tab for the output, and it went to the right of my text editor; I expect output below. The formatting was strange too ... the colors and the font seemed to not fit atom very well to me. I haven't played with script-runner beyond this test, so maybe it's just a matter of aesthetics, but that kind of matters I think. I don't know the differences beyond how they look.
When I ran script-runner just now, I got this new tab for the output, and it went to the right of my text editor; I expect output below.
This is a configurable option in the preferences of the plugin. Perhaps it should be more prominent in the README?
The formatting was strange too ... the colors and the font seemed to not fit atom very well to me.
You can choose light or dark theme in the preferences.
I haven't played with script-runner beyond this test, so maybe it's just a matter of aesthetics, but that kind of matters I think. I don't know the differences beyond how they look.
I agree with that and understand where you are coming from. I am working right now on updating the view code to make it a bit nicer to look at.
@seanodell Okay, most of the points you raised are now addressed in the latest release. If you like try it out and let me know what you think.
[Enter steps to reproduce below:]
Create a shell script named something.sh and give it these contents:
Execute it
Atom Version: 1.12.7 Electron Version: 1.3.13 System: Mac OS X 10.11.6 Thrown From: script-runner package, v2.0.1
Stack Trace
Uncaught TypeError: Bad argument
Commands
Config
Installed Packages