Closed maxbrunsfeld closed 7 years ago
Thank you for the heads up.
This should be pretty easy to fix.
Okay this has been fixed here https://github.com/ioquatix/script-runner/commit/1023a694a4202c0e3eb920b6269a6f072a1d504f feel free to provide any feedback if I haven't done it right.
Hi! Thanks for maintaining the script-runner package!
In Atom v1.19, we will release a major change to Atom's core text buffer data structure. As part of this change, we have made
TextBuffer.save
asynchronous; rather than blocking until the save is complete, it now immediately returns aPromise
that resolves when the save is complete. Because of this, a few other Atom APIs that usesave
have similarly become async:Pane.close
TextBuffer.save
TextEditor.save
Pane.saveItem
Pane.saveItemAs
Pane.saveActiveItem
Pane.saveActiveItemAs
Pane.saveItems
Workspace.saveActivePaneItem
Workspace.saveActivePaneItemAs
Effects on this package
We think this package could be impacted by this upgrade because it calls the changed methods in the following places:
TextEditor.save
We found these calls using a regex search, so this list might be incomplete, and it might contain some false positives.
What to do about the change
It should be pretty easy to adjust your package code and/or tests to work with the new async behavior, and to simultaneously keep it working with older versions of Atom. Here are some examples of pull requests we opened on our bundled packages to cope with the change:
Please let me know if you have any questions. I would be happy to help!