Closed caub closed 6 years ago
Yea sorry, it's a bit cleaner, but still a few diffs, I used prettier. If it's still not good I'll try to copy paste the original back
Please avoid all formatting changes, just submit a PR with the actual functionality. I don't really mind how that part is formatted, but don't just reformat the entire code base.
I took a bit of time, but well, sorry, I can't manage to do more for recovering fully the old formatting. I don't think it matters much :)
tell me if it's still a blocker
Thanks for taking the time to make this. I did implement something you suggested, but generally this PR is not possible to merge.
Still no user configurable ext->commands? well too bad, it's pretty simple tho
I want to add it, but how it was done wasn't good enough - primarily that you deleted all the existing commandMap which is important. I may work on this, but if you are willing to receive my advice, we can open a new PR. Let me know what you'd like to do. I value your contributions.
I'm sure this is a great PR but you've reformatted the entire code base. Please fix your PR :)