search

iorate / ublacklist

Blocks specific sites from appearing in Google search results
https://iorate.github.io/ublacklist/
MIT License
5.68k stars 292 forks source link

Ublacklist not working when I sign in my google account #301

Closed Bizarewold closed 1 year ago

Bizarewold commented 1 year ago

Expected Behavior

Ublacklist functions normally.

Actual Behavior

Links are not blocked and the "block this site" is missing as well.

Steps to Reproduce the Problem

  1. The extension working as intended when I do not login in my google account. Annotation 2022-12-15 135653
  2. I login in.
  3. Any functions of the extension disappear. Annotation 2022-12-15 135642

Specifications

Some solutsions I have tried but did not work: Turning all other extentions off; Only turn on ublacklist in incognito mode; Cleared all caches and cookies; Update/Reinstall Chrome (current Chrome Version 108.0.5359.125);

The extension worked fine before (to be exact, before google's new endless scrolling, but someone else has raised that issue) but now any funtions do not show up and I fail to find the reason. Would appriciate any solutions to this. Thanks in advance!

melfar87 commented 1 year ago

Came here to report the same thing. Almost had a heart attack when Quora reappeared in Google search results. Chrome 108.0.5359.125

Edit: The extension works when signed out of Google (Incognito session).

radley commented 1 year ago

Same behavior here: only works when signed out of Google. Using latest macOS & Firefox.

nickodell commented 1 year ago

I just did a search for "blarg" while logged in and logged out. I compared the HTML for a search result provided by Google in both cases.

Signed IN:

<div class="Z26q7c UK95Uc jGGQ5e" data-header-feature="0">
  <div class="yuRUbf"><a href="https://www.youtube.com/@BlargMyShnoople" data-jsarwt="1" data-usg="AOvVaw3mffKdMYBjqDR50snUBIX0" data-ved="2ahUKEwiLua_T3Pz7AhVXFzQIHfa5DKgQFnoECB0QAQ"><br>
      <h3 class="LC20lb MBeuO DKV0Md">Blarg - YouTube</h3>
      <div class="TbwUpd NJjxre"><cite class="iUh30 qLRx3b tjvcx" role="text">https://www.youtube.com<span class="dyjrff qzEoUe" role="text"> › @BlargMyShnoople</span></cite></div>
    </a>
    <div class="B6fmyf">
      <div class="TbwUpd"><cite class="iUh30 qLRx3b tjvcx" role="text">https://www.youtube.com<span class="dyjrff qzEoUe" role="text"> › @BlargMyShnoople</span></cite></div>
      <div class="rnBE4e">
        <div jscontroller="exgaYe" data-bsextraheight="0" data-frm="true" data-isdesktop="true" data-movewtractions="true" jsdata="l7Bhpb;_;CnMHDI cECq7c;_;CnMHDQ" data-ved="2ahUKEwiLua_T3Pz7AhVXFzQIHfa5DKgQieYJegQIHRAE">
          <div role="button" tabindex="0" jsaction="RvIhPd" class="XKprh">
            <div class="PkoSMe" aria-label="More options" role="button" tabindex="0"><span jsname="I3kE2c" class="S003Ke ZoN4Lb z1asCe SaPW2b" style="height:18px;line-height:18px;width:18px"><svg focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24">
                  <path d="M12 8c1.1 0 2-.9 2-2s-.9-2-2-2-2 .9-2 2 .9 2 2 2zm0 2c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2zm0 6c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2z"></path>
                </svg></span></div>
          </div><span jsname="zOVa8" data-ved="2ahUKEwiLua_T3Pz7AhVXFzQIHfa5DKgQh-4GegQIHRAF"></span>
        </div>
      </div>
    </div>
  </div>
</div>
<div class="Z26q7c UK95Uc" data-content-feature="1">
  <div class="VwiC3b yXK7lf MUxGbd yDYNvb lyLwlc lEBKkf" style="-webkit-line-clamp:2"><span>Matt(<em>Blarg</em>) I upload gaming content :) New video every Tuesday, Friday, and Sunday!</span></div>
</div>

Signed OUT:

<div class="Z26q7c UK95Uc jGGQ5e" data-header-feature="0">
  <div class="yuRUbf"><a href="https://www.youtube.com/@BlargMyShnoople" data-jsarwt="1" data-usg="AOvVaw3mffKdMYBjqDR50snUBIX0" data-ved="2ahUKEwje5uzM3Pz7AhVABTQIHeAUAFgQFnoECBQQAQ"><br>
      <h3 class="LC20lb MBeuO DKV0Md">Blarg - YouTube</h3>
      <div class="TbwUpd NJjxre"><cite class="iUh30 qLRx3b tjvcx" role="text">https://www.youtube.com<span class="dyjrff qzEoUe" role="text"> › @BlargMyShnoople</span></cite></div>
    </a>
    <div class="B6fmyf">
      <div class="TbwUpd"><cite class="iUh30 qLRx3b tjvcx" role="text">https://www.youtube.com<span class="dyjrff qzEoUe" role="text"> › @BlargMyShnoople</span></cite></div>
      <div class="eFM0qc"></div>
      <div class="csDOgf">
        <div>
          <div jsaction="KyPa0e:RvIhPd;wjOG7e:edHC5b;al5F3e:edHC5b;">
            <div role="button" tabindex="0" jsaction="RvIhPd" jsname="I3kE2c" class="iTPLzd GUHazd lUn2nc eY4mx" style="padding-bottom:20px;padding-right:5px;position:absolute" aria-label="About this result"><span jsname="czHhOd" class="D6lY4c"><span jsname="Bil8Ae" class="xTFaxe IjabWd z1asCe SaPW2b" style="height:18px;line-height:18px;width:18px"><svg focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24">
                    <path d="M12 8c1.1 0 2-.9 2-2s-.9-2-2-2-2 .9-2 2 .9 2 2 2zm0 2c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2zm0 6c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2z"></path>
                  </svg></span></span></div><span jsname="zOVa8" data-ved="2ahUKEwje5uzM3Pz7AhVABTQIHeAUAFgQh-4GegQIFBAF"></span>
          </div>
        </div>
      </div>
    </div>
  </div>
</div>
<div class="Z26q7c UK95Uc" data-content-feature="1">
  <div class="VwiC3b yXK7lf MUxGbd yDYNvb lyLwlc lEBKkf" style="-webkit-line-clamp:2"><span>Matt(<em>Blarg</em>) I upload gaming content :) New video every Tuesday, Friday, and Sunday!</span></div>
</div>

One difference is the removal of <div class="eFM0qc"></div>. Looking at the source code, that identifier is mentioned many times, so it seems like it might be the cause.

Edit: just did an experiment, where I replaced eFM0qc with rnBE4e everywhere in src/scripts/search-engines/google-desktop.ts. It makes the block site button show up again for signed-in users, and blocking works. Also, the block button shows up in a weird place.

However, this change breaks uBlacklist if you are signed out of google.

tomdiary commented 1 year ago

I was in a similar situation, my environment was MacOS & Chrome

iorate commented 1 year ago

Thank you for your report. This issue will be fixed in v8.2.3.

Note: This issue only occurs when you are logged in and your language and region are set to English and US, respectively.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 8.2.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: