Trouble with AMO review

I am having trouble with AMO review right now. Because the Firefox add-on, at least the older versions, could be removed from AMO, I will explain the situation here. I may have made a mistake in not uploading source code for add-ons bundled by webpack recently.

12/12/2022

I uploaded v8.2.2 and it got pending review.

Title: Mozilla Add-ons: uBlacklist 8.2.2 is pending review

Thank you for submitting your add-on uBlacklist 8.2.2 to addons.mozilla.org. Your submission is taking longer than usual to be reviewed and signed. This process could take a few extra hours and up to a couple of days.

Prior to v8.2.1, the review process was completed immediately.

12/14/2022

Removal from AMO was noticed.

Title: Mozilla Add-ons: uBlacklist will be disabled on addons.mozilla.org

Due to issues discovered during the review process, one or more versions of your add-on uBlacklist will be disabled on addons.mozilla.org in 14 day(s). Please see the reviewer’s comments below for more information.

Details: Your add-on contains minified, concatenated or otherwise machine-generated code. If you haven't done so, you need to provide the original sources, together with instructions on how to generate the exact same code used in the add-on. Source code must be provided as an archive and uploaded using the source code upload field, which can be done during submission or on the version page in the developer hub. Please read through the instructions at https://extensionworkshop.com/documentation/publish/source-code-submission/ .

Version(s) affected: 2.0.5, 2.0.6, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.0, 2.5.1, 3.0.0, 3.0.1, 3.0.2, 3.0.3, 3.1.0, 3.1.1, 3.1.2, 3.1.3, 3.1.4, 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.5, 3.3.0, 3.3.1, 3.3.2, 3.3.3, 3.3.4, 3.4.0, 3.4.1, 3.4.2, 3.4.3, 3.4.4, 3.4.5, 3.5.0, 3.6.0, 3.6.1, 3.6.2, 3.6.3, 3.6.4, 3.6.5, 3.6.6, 3.6.7, 3.7.0, 3.8.0, 3.8.1, 3.8.2, 3.8.3, 3.8.4, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 4.2.0, 4.2.1, 4.2.2, 4.2.3, 4.2.4, 4.2.5, 4.2.6, 4.3.0, 4.3.1, 4.3.2, 4.3.3, 4.4.0, 4.4.1, 4.5.0, 4.6.0, 4.7.0, 4.7.1, 4.7.2, 4.8.0, 4.8.1, 4.8.2, 4.8.3, 4.8.4, 4.9.0, 4.10.0, 4.10.1, 4.10.2, 4.11.0, 4.11.1, 4.11.2, 5.0.0, 5.0.1, 5.1.0, 5.1.1, 6.0.0, 6.0.1, 6.0.2, 6.1.0, 6.1.1, 6.2.0, 6.2.1, 6.3.0, 6.3.1, 6.3.2, 6.3.3, 6.3.4, 6.3.5, 6.3.6, 6.4.1, 6.5.0, 6.6.0, 6.6.1, 6.6.2, 6.7.0, 6.8.0, 6.8.1, 6.8.2, 6.8.3, 6.9.0, 6.10.0, 6.11.0, 6.12.0, 6.13.0, 6.14.0, 6.15.0, 7.0.0, 7.0.1, 7.1.0, 7.2.0, 7.2.1, 7.2.2, 7.2.3, 7.3.0, 7.4.0, 7.4.1, 7.4.2, 7.4.3, 7.5.0, 7.5.1, 7.5.2, 7.5.3, 7.6.0, 7.7.0, 7.8.0, 7.8.2, 7.8.3, 7.8.4, 7.8.5, 8.0.0, 8.0.1, 8.0.2, 8.1.0, 8.1.1, 8.2.0, 8.2.1, 8.2.2

It's true that recent versions of uBlacklist is bundled with npm packages by webpack and I haven't submitted the source code because AMO does not provide API to upload it, but it's strange that older versions not bundled by webpack are scheduled to be removed.

I uploaded the source code for v8.2.2 and v8.2.1 with the message:

To build this add-on, Node.js >= 16 and Yarn are required.

$ yarn

$ yarn build firefox production

The add-on will be built into dist/firefox/production/.

12/16/2022

I received a message from a reviewer.

We have tried to build your add-on using the provided sources on Ubuntu 20.04 using node v14.17.0, npm 6.14.13, but the process aborted with errors. Please see https://paste.mozilla.org/Jm0BgXDh for the build output. Also, please test your build in a clean environment to make sure it is reproducible. If necessary, update the source package and/or the instructions to build.

I replied:

Please use Node.js >= 16.

12/17/2022

I uploaded v8.2.3 to deal with #299 and #301, accompanied by the source code.

v8.2.2 was automatically disabled and v8.2.3 became pending review.

12/18/2022

So far no response has been received.

iorate / ublacklist