iorate / ublacklist

Blocks specific sites from appearing in Google search results
https://iorate.github.io/ublacklist/
MIT License
5.68k stars 294 forks source link

Extension broken in DuckDuckGo #346

Closed test6678 closed 1 year ago

test6678 commented 1 year ago

Blocking search results no longer works in DuckDuckGo. Other search engines (Google, Yandex, etc.) seem to be unaffected.

bunnyhero commented 1 year ago

just noticed this today too.

ghjb004 commented 1 year ago

Also not working on DuckDuckGo in Safari, I am not sure if this is a separate issue. Is there a Safari update on the way?

AnityEx commented 1 year ago

not working on edge, just downloaded toady for this and i come here and see its not working lol

1Phase1 commented 1 year ago

Can confirm it's not working on DuckDuckGo on Firefox.

lynnewu commented 1 year ago

Chrome/Windows 10. Same problem. Stopped working with DuckDuckGo sometime in the past week. Working on Google search.

parapacem commented 1 year ago

DuckDuckGo IMAGE, VIDEO and NEWS all working, not web search though Yandex browser, have tried two devices both using Windows 10

MediaEU commented 1 year ago

Is this not strange that no one has at least an assumption why it doesn't work anymore? Debian/Chrome Version 105.0.5195.125 (Official Build) (64-bit)

bunnyhero commented 1 year ago

if i had to guess, duckduckgo probably changed their CSS or something like that.

ghjb004 commented 1 year ago

as of today the "block this site" button is showing in the Safari DDG images and videos tabs but not the "all results" tab. Blocked sites appear to be blocked in those tabs but not in the "all results tab. Can other users can confirm this?

SaunaThenColdBath commented 1 year ago

@ghjb004 I'm using the extension on Firefox. I confirm the same behavior. The filter is not working on All result tab, and no 'block this site' button. However, the button is shown on Images, News, Video tab.

KirkH420 commented 1 year ago

Not working for me in on DDG either.

lilibyte commented 1 year ago

The search engine handler duckduckgo.ts defines target: '.results > .nrn-react-div' but I don't see .results or .nrn-react-div in the duckduckgo search result HTML. I think this should be replaced with target: '.react-results--main'

edit: hm if I understand what the source is doing correctly, maybe it should actually be .react-results--main article[data-testid="result"] instead since that matches the card for the result itself.

ghjb004 commented 1 year ago

iorate様 お願い致します!

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 8.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Jon-guy30 commented 1 year ago

This extension is not updated in firefox AMO. Is the 8.3.1 version going to be released there? I just installed this extension, it installed the broken 8.3.0 version, is Firerfox going to get the 8.3.1 version? Chrome says it has the 8.3.1 release.

Thanks for the update!

ghjb004 commented 1 year ago

Just installed the Safari update. Many thanks, working again.