search

iorate / ublacklist

Blocks specific sites from appearing in Google search results
https://iorate.github.io/ublacklist/
MIT License
5.68k stars 292 forks source link

image suggestions box not being filtered in the "All" section of google search #462

Closed STUAAAAAAAAAART closed 5 months ago

STUAAAAAAAAAART commented 6 months ago

Expected Behavior

image suggestions box (not the image search section, that's working) also getting filtered and blacklist items hidden in there

Actual Behavior

image suggestions box not being filtered in the "all" section of google search

image

sites in that box exist in the filter list

Steps to Reproduce the Problem

  1. ensure filter(s) in ublacklist contain *://*.prompthunt.com/*
  2. google search for pixar jean baptiste
    (i know that's not how jon batiste's name spelt, i'm going off memory and couldn't recall)

i'm not sure of other terms that would produce that scenario as well, but that search result seems to be consistent at the moment

Specifications

any other comments

it's google's loosening grip on quality and abstracting away user-sided control that i have to resort to using this extension. thanks for making it work for the most part

aug-dev commented 5 months ago

I'll look into this once I finish working on another feature.

aug-dev commented 5 months ago

Adding a rule to support this was surprisingly simple... but there is a problem.

If we click the button to load more images, they slip through the rule and show up anyways:

img-blocking-demo.webm

Something similar happens when the "Images" section doesn't show up in the first page (before auto-loading new content.)

This seems to be an issue with the extension currently, where the ability to detect dynamic content can be hit or miss sometimes (e.g. #446).

This is not a trivial problem to solve (at least I think), but I can tell that is something we are aware of.

iorate commented 5 months ago

We can use pagerHandlers to extract search results from dynamically added elements. https://github.com/iorate/ublacklist/blob/4a9a5e0d11a07b26f0aecc87586628bdb3754381/src/scripts/search-engines/google-desktop.ts#L469-L489

aug-dev commented 5 months ago

Oh wow!

Not going to lie, I hadn't yet deciphered what pageHandlers were used for. 😅

This is cool! I was trying to fix this issue right now, later this day I'll look into it.

aug-dev commented 5 months ago

Here's the PR solving this issue #467

:)

github-actions[bot] commented 5 months ago

:tada: This issue has been resolved in version 8.7.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: