search

ios-control / ios-sim

Command-line application launcher for the iOS Simulator
Apache License 2.0
1.5k stars 253 forks source link

Removed plist argument from install function because it isn't used and caused the devicetypeid not to be recognized #180

Closed czambran closed 9 years ago

czambran commented 9 years ago

The install function in lib.js was expecting as a second argument the the Info.plist path but this is never passed and the function calculates it based on the App path. This was causing that the devicetypeid not be recognized even though it was being passed because it was passed as the second argument to the function by the install function in commands.js

Software Versions: 1.MacOS version: 10.10.5

  1. ios-sim version: 5.0.2
  2. Xcode version: Xcode 7.0.1 Build version 7A1001
  3. xcode-select: /Applications/Xcode.app/Contents/Developer
  4. gcc version: Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/c++/4.2.1 Apple LLVM version 7.0.0 (clang-700.0.72) Target: x86_64-apple-darwin14.5.0 Thread model: posix
shazron commented 9 years ago

Good catch! This is where it was called for reference: https://github.com/czambran/ios-sim/blob/bbfd40a0ab320fe3073fa0820c5461d561f50432/src/commands.js#L72