search

ios-control / ios-sim

Command-line application launcher for the iOS Simulator
Apache License 2.0
1.49k stars 253 forks source link

It seems like iOS device names have changed again... #224

Closed aharbick closed 6 years ago

aharbick commented 6 years ago

On ios-sim 6.1.2 with XCode 9.0 and the iOS 11.0 runtime I get this error:

No available runtimes could be found for "iPad Pro (12.9-inch)".

I chase this all the way back to the fact that the devices now have a hypen again.

    iPad Pro (9.7-inch) (B22EE94B-DFB7-4E8E-9857-B5AFC3714C5A) (Shutdown)
    iPad Pro (12.9-inch) (B0157B87-16AB-4919-8BE1-96E740AAA794) (Booted)
    iPad Pro (12.9-inch) (2nd generation) (07A54F54-4C2A-4EB4-A3A1-6AEFEB1177A7) (Shutdown)
    iPad Pro (10.5-inch) (C04DED7A-E655-4F20-96D8-1D2EA9183E01) (Shutdown)

Getting rid of the device name filtering solves the problem.

surajpindoria commented 6 years ago

Lovely, thanks Apple 😉 ! Appreciate the PR @aharbick, I will review this.

shazron commented 6 years ago

Fails the CI. Also I don't think it's as easy as it looks since ios-sim might still be used on Xcode 8...

aharbick commented 6 years ago

Fair point @shazron. How about this simplification? Keep the device name filtering but when doing the runtime lookup fallback to looking up without the filtered device name.