search

ios-control / ios-sim

Command-line application launcher for the iOS Simulator
Apache License 2.0
1.49k stars 253 forks source link

Support iPhone XS, iPhone XS Max and iPhone XR #236

Closed EtienneLem closed 5 years ago

EtienneLem commented 5 years ago

Addresses #235

Basically always toLowerCase device names when comparing, because depending on where the device name comes from there are many different formatting, i.e.:

Also normalized the ʀ character (R != ʀ). Comparing is always false otherwise even when toLowerCase().

Note for Cordova users:

Until this is merged / released and Cordova updates its dependencies, you may want to add ios-sim to your devDependencies and replace in your workflow:

cordova run --target=DEVICE_TYPE_ID

by

ios-sim launch platforms/ios/build/emulator/YOUR_APP.app --devicetypeid=DEVICE_TYPE_ID
shazron commented 5 years ago

I just integrated #239 for ES6 support which is failing your changes. Rebase from master, thanks!

shazron commented 5 years ago

No need for rebase, I did it through Github. Now your PR is failing the eslint check, can you do:

npm install
npm run eslint -- --fix
EtienneLem commented 5 years ago

Done 🤘

brodycj commented 5 years ago

Thanks @EtienneLem for fixing this!