ios-control / ios-sim

Command-line application launcher for the iOS Simulator
Apache License 2.0
1.49k stars 253 forks source link

Handle addition of iPhone XS (Max) and XR (#235) #238

Closed ajcrites closed 5 years ago

ajcrites commented 5 years ago

Like the iPad Pro, these have device names that do not match the device identifier. This does a replacement via filterDeviceName

Fixes #235

shazron commented 5 years ago

Your PR is failing the eslint check, can you do:

npm install
npm run eslint -- --fix

Also, I just integrated #239 for ES6 support. Rebase from master, thanks!

shazron commented 5 years ago

Sorry - no need for rebase, I just did it through Github.

shazron commented 5 years ago

Sorry for not noticing earlier, but I believe this is already handled by #236