search

ios-control / ios-sim

Command-line application launcher for the iOS Simulator
Apache License 2.0
1.49k stars 253 forks source link

Log device information #255

Closed janpio closed 4 years ago

janpio commented 5 years ago

Adds 3 log calls before handing over to simctl to do the actual launching.

Part of #254

codecov[bot] commented 5 years ago

Codecov Report

Merging #255 into master will decrease coverage by 0.83%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   85.85%   85.01%   -0.84%     
==========================================
  Files           9        9              
  Lines         304      307       +3     
  Branches       55       55              
==========================================
  Hits          261      261              
- Misses         32       35       +3     
  Partials       11       11
Impacted Files Coverage Δ
src/commands/launch.js 30% <0%> (-2.44%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd6e3ba...2f81231. Read the comment docs.

shazron commented 4 years ago

hmm can't reopen to re-trigger the CI. it couldn't have been merged anyway because the PR repo was deleted.

janpio commented 4 years ago

it couldn't have been merged anyway because the PR repo was deleted.

That doesn't make a difference to Github UI, but 🤷‍♀ . Not that important.

shazron commented 4 years ago

it does make a difference, it disables the merge button.