search

ios-control / ios-sim

Command-line application launcher for the iOS Simulator
Apache License 2.0
1.49k stars 253 forks source link

Simctl command now returning "isAvailble" instead of "availblity" with list command. #258

Closed vibhor-ios closed 5 years ago

vibhor-ios commented 5 years ago

Review : @shazron, @brodybits

vibhor-ios commented 5 years ago

@shazron, @brodybits can you please Review and merge this?

erisu commented 5 years ago

@vibhor-ios I noticed you are targeting the 8.x branch. Can you please change the target branch to master so it can merged in?

vibhor-ios commented 5 years ago

@erisu We are currently using 8.x version. if we merge into master we have to change code our project. So can you please merge this into 8.x only?

erisu commented 5 years ago

I think it would be better if we merge this into master first so when 9.x is released the changes are available and not lost.

For 8.x, it may be possible that we can cherry-pick the commit, but I will confirm with one other.

Even though it is possible to cherry-pick in the reverse order, our typical workflow is normally merging first into the master branch and then merging the master branch into the existing released major branch (8.x) if there are no major changes. If the master already contains major changes, we would create a special PR to cherry-pick items that should be backtracked into existing majors.

vibhor-ios commented 5 years ago

@erisu File structure of this repo is different in 8.x and master. File in which i made changes not exists on master branch, since we are using 8.0.1 version in our project this is working fine.

erisu commented 5 years ago

Thank you for clarifying about the project structure difference.

erisu commented 5 years ago

If you also have time to make the change and submit a PR for master, that would be awesome.

This would help us make sure that the fix is also applied in 9.x's release, when released.

vibhor-ios commented 5 years ago

Hi @erisu can you please release "8.x" branch? So that i can use that release in our codebase.

vibhor-ios commented 5 years ago

@erisu Just reminder!! can you please Release "8.x" branch?

erisu commented 5 years ago

@vibhor-ios ios-sim@8.0.2 was already released a day ago. https://www.npmjs.com/package/ios-sim

dpogue commented 5 years ago

This needs to be fixed on master as well:

https://github.com/ios-control/ios-sim/blob/1ded982e75b2e8e13d5178aa41594c1688abb769/src/commands/showsdks.js#L22

https://github.com/ios-control/ios-sim/blob/bd6e3ba0a81304d9fc3d18c83deed10145ba207f/src/helpers.js#L108-L109

https://github.com/ios-control/ios-sim/blob/bd6e3ba0a81304d9fc3d18c83deed10145ba207f/src/helpers.js#L310-L311

Some tests should be updated too, to actually test that we correctly handle isAvailable instead of availability.