iosphere / ISHPermissionKit

A polite and unified way of asking for permission on iOS
https://iosphere.de
Other
614 stars 44 forks source link

Ensure 'CFBundleVersion' is set #102

Closed shagedorn closed 5 years ago

shagedorn commented 5 years ago

When archiving/uploading with Xcode 10.2, this will otherwise throw this upload error:

ERROR ITMS-90056: "This bundle /Frameworks/ISHPermissionKit.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion. Please find more information about CFBundleVersion at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleversion"

ISH_BUNDLE_VERSION was never set.

shagedorn commented 5 years ago

@CooperRS will double-check, but I believe it is. The actual value also doesn't really matter… only because the old variably was missing entirely, Xcode decided to skip the Info Plist key entirely.

shagedorn commented 5 years ago

Cleaned up a bit, one target was indeed overwriting the build number.