iosphere / ISHPermissionKit

A polite and unified way of asking for permission on iOS
https://iosphere.de
Other
614 stars 44 forks source link

Refactor bulk state queries to fix issues for configurable requests #55

Closed felixLam closed 8 years ago

felixLam commented 8 years ago

The issue with the previous implementation was that the requests would not be properly configured leading to false states. The current setup with the PermissionsViewController at the center does not really allow for a query about all granted permissions. If there is sufficient interest in getting a set of all granted permissions (as opposed to the lack of no request-able permissions), we would need to refactor the dataSource away from the permissions view controller into a separate protocol.

This PR removes the method grantedPermissionsForCategories. The previous method requestablePermissionRequestsForCategories is now simply the permissions viewcontroller's permissionCategories .

shagedorn commented 8 years ago

👍