search

iosphere / ISHPullUp

Vertical split view controller with pull up gesture as seen in the iOS 10 Maps app
https://iosphere.de
MIT License
495 stars 60 forks source link

Additional Safe Area Height in iPhone X #76

Open MrJai opened 6 years ago

MrJai commented 6 years ago

Hi, thanks for such an amazing view controller that saved me many hours of work, and it works great. I just face one issue recently and that is specific to iPhone X.

There is additional 34 pixel at the bottom of screen when running on iPhone X. You can see the same in the sample maps app. There should be an option to choose from if a developer wants bottom of super view to be the reference or bottom of safe area to be the reference.

If you think there can be a way around to fix it, then please help me out.

matthewharries commented 6 years ago

I agree! For now I just did the following to calculate my height return tableView.contentSize.height + (UIApplication.shared.keyWindow?.safeAreaInsets.bottom ?? 0)