iossifovlab / gpfjs

MIT License
0 stars 0 forks source link

Save dataset id to state #1078

Closed IlinaGergova closed 3 months ago

IlinaGergova commented 3 months ago

Background

Saving Dataset object in state causes bugs.

Aim

To save dataset id only in state.

Implementation

Save dataset id in state and if the component need the dataset it makes request using datasetsService method getDataset(datasetId: string) when it loads the id from state. This led to issues when validating regions filter after loading a query (share/save query) - genome wasn't passed on time. So the way of passing the genome is changed.

iordanivanov commented 3 months ago

I also noticed a 404 error on your branch where the app was making requests to datasets/details, but this might not be from your changes