Closed rienafairefr closed 4 years ago
update:
integration tests are passing. In the new API some endpoints (I saw it on DELETE /profiles/{name}) can return non-200 codes that are not errors, for exemple deleting a profile succesfully returns 204. cli-tools framework can only handle 200 and 500 as we've already discussed. I added a workaround for that particular endpoint. we'll have to do the same for other endpoings (like mobility, I think)
I'll add something to recover the coverage and then it's OK for me
update:
204
, then the CLI shows that, no content:
(cli-tools) matthieu@zurkus:~/iot-lab-dev/parts/cli-tools (new_api)$ iotlab-profile addm3 -n test_m3 -sniffer -channels 11
{
"nodearch": "m3",
"power": "dc",
"profilename": "test_m3",
"radio": {
"channels": [
11
],
"mode": "sniffer",
"num_per_channel": null,
"period": null
}
}
(cli-tools) matthieu@zurkus:~/iot-lab-dev/parts/cli-tools (new_api)$ iotlab-profile del -n test_m3
(cli-tools) matthieu@zurkus:~/iot-lab-dev/parts/cli-tools (new_api)$
Tested the robot endpoints visible through iotlabcli, seems ok.
@fsaintma there might be a edge case bug in the API with update mobility
: when sending node list []
it's doing the update on all the robots in the experiments.
:+1: seems good to merge for future v 3.0 release
@rienafairefr ok for None in the case of 204 return. Should you resolve the rebase conflicts ? It seems that you have some commits of me in this PR :) After I will merge it.
Yep, this branch had diverged in a different place. I've rebased on top of your upstream/new_api
branch and all seems good now
I recommend a squash, there's a lot of small fix commits ^^
I already did some stuff but didn't push it. :-|
summary:
iotlab-experiment deployment
subcommandiotlab-profile addm3
with just the name works, in the new API, it fails with 500iotlab-profile addm3
when the profile already exists works without errors, in the new API it fails with code 500integration tests are not yet fully passing, but it should be OK by the end of the day, I'll update this PR