iot-lab / cli-tools

IoT-LAB CLI tools
Other
17 stars 14 forks source link

fixes New api #41

Closed rienafairefr closed 4 years ago

rienafairefr commented 5 years ago

I already did some stuff but didn't push it. :-|

summary:

integration tests are not yet fully passing, but it should be OK by the end of the day, I'll update this PR

rienafairefr commented 5 years ago

update:

integration tests are passing. In the new API some endpoints (I saw it on DELETE /profiles/{name}) can return non-200 codes that are not errors, for exemple deleting a profile succesfully returns 204. cli-tools framework can only handle 200 and 500 as we've already discussed. I added a workaround for that particular endpoint. we'll have to do the same for other endpoings (like mobility, I think)

I'll add something to recover the coverage and then it's OK for me

rienafairefr commented 5 years ago

update:

rienafairefr commented 4 years ago

Tested the robot endpoints visible through iotlabcli, seems ok.

@fsaintma there might be a edge case bug in the API with update mobility: when sending node list [] it's doing the update on all the robots in the experiments.

rienafairefr commented 4 years ago

:+1: seems good to merge for future v 3.0 release

fsaintma commented 4 years ago

@rienafairefr ok for None in the case of 204 return. Should you resolve the rebase conflicts ? It seems that you have some commits of me in this PR :) After I will merge it.

rienafairefr commented 4 years ago

Yep, this branch had diverged in a different place. I've rebased on top of your upstream/new_api branch and all seems good now

rienafairefr commented 4 years ago

I recommend a squash, there's a lot of small fix commits ^^