search

iot-root / garden-of-eden

Truly own that which is yours!
GNU General Public License v3.0
22 stars 6 forks source link

dimmer function in the led.py turns off lights #39

Closed doubleplusthink closed 2 months ago

doubleplusthink commented 10 months ago

For me, when I used the dimmer() function in the LED class, it turned off my gardyn lights.

Can someone repro this to see if it's a problem for them as well?

iot-root commented 10 months ago

Not sure we need anything other than on, off, get and adjust. I looked at that function and I dont see the point of it or "lighter"

ammaratef45 commented 10 months ago

I think min here was supposed to be max - likely a bug https://github.com/iot-root/gardyn-of-eden/blob/93ac7cae6adc6d5b98c1c75f967876254ae9883f/sensors/led.py#L74

iot-root commented 2 months ago

closing since code was refactored and no longer using a dim function