search

iot-root / garden-of-eden

Truly own that which is yours!
GNU General Public License v3.0
22 stars 6 forks source link

Improve hardware detection #57

Open petercorrea opened 2 months ago

petercorrea commented 2 months ago

Improve the ability to detect hardware presence during runtime.

When setting and get sensor data, api returns successful responses despite hardware being disconnected.

iot-root commented 3 weeks ago

@petercorrea should we close since changes per #74 should addresss this?

MWEJ commented 3 weeks ago

I think this covers more than #74 As an example, my pump wasn't working due to corrosion, but the unit tests/API tests stated that the pump was successfully run. The pump run can be detected by looking at the BusCurrent to see if it's higher than 0 after the pump is started.

petercorrea commented 3 weeks ago

@iot-root MWEJ is correct. This is more about addressing false positives in hardware detection, and sending better api responses to indicate that.