search

iotabots / iotabots.io

Landing page website for IOTABOTS
https://iotabots.io/
22 stars 14 forks source link

fix failing build #16

Closed hristo-mavrodiev closed 2 years ago

hristo-mavrodiev commented 2 years ago

The new commits to the website are not deployed, because the github actions are failing. This should resolve the issue with image

image

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/iotabots/iotabots-io/6pUTTYvBJwRoECuB4nmbJz5cKmeV
✅ Preview: https://iotabots-io-git-fork-hristo-mavrodiev-fix-failed-build-iotabots.vercel.app

huhn511 commented 2 years ago

Hey @hristo-mavrodiev,

we currently using [Vercel]{https://vercel.com} for deployment, instead of GitHub. That's because we using a image optimized function from Next.js, which does not work with the static build option for GitHub pages.

Does this works with this fix? Because Vercel is not free like GitHub pages and i would love to switch again :)

hristo-mavrodiev commented 2 years ago

I found this workaround https://github.com/vercel/next.js/issues/21079 to eliminate the need for vercel

https://github.com/vercel/next.js/discussions/21480#discussioncomment-305312

I think that this is going to switch the image optimization engine from vercel to imgix could be also one from the list: https://nextjs.org/docs/api-reference/next/image#built-in-loaders

I guess that imgix is a paid API and there is a usage limit for optimizations. What do you think about the idea: if we optimize the images in different resolutions offline, so there isn't any onthefly optimization that is requiring an API or nodejs server?