search

iotait / fundraising

0 stars 1 forks source link

19 restrict access #40

Closed tannerwernecke closed 4 years ago

tannerwernecke commented 4 years ago

Addresses #19

Information should be selectively hidden and shouldn't be available to everyone. In order to do this, we need to restrict access using devise. This updates all controllers, models and views to use the functionality Devise provides.

--Matt, I apologize for such a messy PR. After we started digging into it Tuesday and changing things, I jumped into it ready to clean it up so we would have our base code to work from. The thought of having clean commits/branches slipped my mind until today. From here on out, I plan on cleaning up those commits/branches and doing a better job of it.

mattzollinhofer commented 4 years ago

I didn't do a full review, but I looked at each place you pointed out and skimmed a little here and there. If you take a look and need to clarify some things let me know, we can do a call tonight if it'd be helpful.

tannerwernecke commented 4 years ago

Thanks for looking at it. I looked through and everything makes sense to me. I don't feel like there's a need on my end to do a call, but if there's something you want to talk through then we can do it.