Closed vlad-ns closed 4 years ago
I have the terrible habit of rewriting history on remote by force pushing amended commits. My apologies for the polution this caused with a duplicated commit link to this issue.
I will try to avoid doing this again.
Code cleanup for bc deamon module done in 7394565cfa8e30c946eb3314ca06055076c9885e
Added new branch for code cleanup issue: https://github.com/iotaledger/access/tree/code_cleanup
Code cleanup for config manager done in 190c70cb42b547d3260675bde2be4fdde41ce69d
Code cleanup for CAN module done in bfd0df84f92597ad337c2784fed140492c0a8eaf
Closed by accident
Code cleanup for CANOPEN module done in bf7208bedf71bb14be7dc8b07570dc07187900ab
Code cleanup for GPS module done in a313742fde77b1b8abfa51f73cbbe36ae0e4c233
Code cleanup for MODBUS module done in 81c01db5e04e10db8bd6af9d2c150201dab377c3
Code cleanup for OBDII module done in 4013ab31c82df41d096ce6b9baa1b78c62140358
Code cleanup for Policy Store was done in cd2b5ea3bf18fb7caed9ecec7a55126c84ceb689.
Additional work here will be addressed in Issue #31
Code cleanup for authDacHelper done in 6159475b8db9615b86cd0115d3b6511e7f09f504
@vlad-ns As stated in TODO comment in this module, only currently supported obligation is "log_event". Should we create issue for obligations expansion?
Code cleanup for Dlog module done in 40cda4d2fa4932ae823b8517314ce0192e63e7d2
Code cleanup for JSON Interface module done in 0c2b1cccaebb4dfe4ebadc2bba97c66d853c693c
Code cleanup for TCP Client module done in cb485f7beb3e0a78e579e2ee3df6f0ecb385fd89
Code cleanup for Time Manager module done in 7afa545bd3b7bb0e96dc2ad3ec085836ce4459c5
Code cleanup for Timer module done in 281e26ee0bd3d28576843036cd6914a0da7f25aa
Code cleanup for Utils String module done in 5863227a7834a60bf67eef6b106bd8a334861367
Code cleanup for psDaemon done in 3354d5bf805913ad28d5c656d6e7ba3ac83366e2
Code cleanup for libdac done in 0720b33bba04335519eac60961d46434420c3803
Some issues are stated in JSON Interface and libdac modules. Should be solved for the next phase of the project.
Code cleanup for PDP module done in 9b84cdbaadee70c676434fc2936927754655fa01 Some issues are left open, should be solved for the next phase of the project.
Code cleanup for PEP module done in 2fd050ce2bf368f60488a44dd9c08d9c2f90b855
Code cleanup for PIP module done in e6d30b99d9957199cc1a0962694b5f2e775956d9
Code cleanup for Resolver module done in f5e90de1d0050c7c24916a814b97a3477310ed6c
Code cleanup for TCP server module done in dc5e18d08d98675280d0c7a4e5f00df97d12171e
Code cleanup for tests done in 4d13b66df18748c64bd6a96a1eab25a3e0c37834
Code cleanup for User Management done in 8aa88b2d922aac0535062db193167ec83b2173da
Code cleanup for Vehicle Dataset done in 1c2de2e7299ff2f638d7196019f9eca7e6464e39
@vlad-ns Additional task should be created in order to refactor current crypto-lib, since there are some issues still left there.
Code cleanup is done, task can be closed.
Summary Code cleanup before public release
Details Remove unused code, replace magic numbers, add comments where needed.
JIRA: AXS-47