search

iotaledger / access-server

Apache License 2.0
14 stars 3 forks source link

Merge new configuration manager #80

Closed djordjeglbvc closed 4 years ago

djordjeglbvc commented 4 years ago

@bernardoaraujor thanks for comments, I'll hop onto it.

Regarding case, my idea was to use camel case for module name part of the symbol, and snake case for method part. For instance if we have module "config manager", and method is "get", function name would be ConfigManager_get, something like that. This would matter only for functions and types visible from header file (API functions and types). Static functions, variables names, etc, would all be snake case, as I prefer it, as well.

We are inconsistent as we never sat down and discussed it, but I think this is good way to make it obvious when you look at the function, you know which module it is from, and what is the function, as we don't have namespaces or classes in C.

bernardoaraujor commented 4 years ago

@djordjeglbvc no problem! case was just a small remark

priority now is to do the wallet integration properly. please study the wallet implementation and ask questions to Sam Chen if necessary.

vlad-ns commented 4 years ago

@djordjeglbvc please fix conflicts. Wallet is a part of the next sprint.

djordjeglbvc commented 4 years ago

Fixed conflicts, renamed cfg_mgr to config_manager.