iotaledger / access-server

Apache License 2.0
14 stars 3 forks source link

[AXS-61] Review ASN Engineering Specs #85

Closed bernardoaraujor closed 4 years ago

bernardoaraujor commented 4 years ago

ASN Engineering Specs were extracted from DAC Design Specification v0.5.docx and XAIN_Embedded Technical Specifications.pdf.

However both documents provide conflicting information, and some of them remain unclear and possibly outdated.

A review by @djordjeglbvc on the ASN section of the Engineering Specification document needs to be done to ensure all information is correct and presented properly.

Review items:

JIRA: AXS-61

djordjeglbvc commented 4 years ago

@vlad-ns would be better suited for reviewing this, as I wasn't directly involved in implementation of these modules

vlad-ns commented 4 years ago

1. Block diagrams for server authentication key exchange and client public key authentication protocol should be replaced with following images: Server authentication key exchange Client public key authentication protocol

2. Add additional explanation for DH public key generation:

After physical connection is established, client generates a Diffie-Hellman (DH) private key. Based on the private key, client computes DH public key.

... using following formula: DH formula where g and p are previously configured constants on both side client and server.

  1. In section Data encryption, decryption and validation bellow formulas add explanation: "A", "B", ... "F" are constants representing ASCII values of those characters

vlad-ns commented 4 years ago

review and update done.