search

iotaledger / entangled

enTangle'd is an amalgamation of all things Tangle
Apache License 2.0
113 stars 66 forks source link

utils: remove pointer to containers #1314

Closed howjmay closed 5 years ago

howjmay commented 5 years ago

Remove not necessary pointer to container.

I opened this draft to make sure I am going on the right way

howjmay commented 5 years ago

@thibault-martinez May you take a galnce is the way I did OK?

howjmay commented 5 years ago

Sorry for the delay, we were having SumSum. It looks good, please fix the clang-format issues, not sure why you touched C++ files.

I guess why I touch cpp files was formater's problem, I will fix this later.

thibault-martinez commented 5 years ago

@HowJMay You can probably set the PR as ready to review now

thibault-martinez commented 5 years ago

Looks like there are issues with the CI though

howjmay commented 5 years ago

Looks like there are issues with the CI though

I am waiting for #1315. On my machine I can't build entangled sucessfully, because of #1315. Therefore, I haven't done a comprehensive testing yet. But thanks for you help me run the CI. Now, I am able to find out the problems ^_<

thibault-martinez commented 5 years ago

You can use the --build_tests_only option of bazel test to bypass this issue.

howjmay commented 5 years ago

That option is really helpful. I run the test and the only test hasn't passed is test_exit_probability_randomizer which would timeout. I think it is caused by some environment setting issue (setting db or something), so I push the current code and wait for the CI result anyway.

howjmay commented 5 years ago

I still not sure what caused my timeout problem, but, whatever, I passed test with command bazel test --build_tests_only --remote_upload_local_results=false //ciri/consensus/... The timeout problem disapear with this command.

thibault-martinez commented 5 years ago

test_exit_probability_randomizer is based on random, if you're extremely unlucky it can fail :trollface:

howjmay commented 5 years ago

test_exit_probability_randomizer is based on random, if you're extremely unlucky it can fail :trollface:

How unlucky I was ..... thanks man