iotaledger / entangled

enTangle'd is an amalgamation of all things Tangle
Apache License 2.0
113 stars 66 forks source link

mam: Use of uninitialised value of size 8 when calling mam_channel_t_set_add #1437

Closed kuhlmannmarkus closed 4 years ago

kuhlmannmarkus commented 4 years ago

Describe the bug I see the following error when running for example the send-msg example binary in valgrind:

==13091== Use of uninitialised value of size 8 ==13091== at 0x1BDC08: mam_channel_t_set_add (mam_channel_t_set.c:20) ==13091== by 0x1BD537: mam_channels_deserialize (channel.c:209) ==13091== by 0x1ABAD7: mam_api_deserialize (api.c:795) ==13091== by 0x1ABF43: mam_api_load (api.c:892) ==13091== by 0x110A7C: main (send-msg.c:32)

The error above is seen, if an API file exists and can be loaded, but it also occurs while creating a fresh API, since mam_channel_t_set_add is called in both cases.

I get this error also with other binaries that call mam_channel_t_set_add.

To Reproduce Steps to reproduce the behavior:

  1. run the send-msg example binary in valgrind.

Expected behavior I dont expect the use of uninitialized memory.

Desktop (please complete the following information):

Additional context I do NOT see any functional problem, but I believe this should be resolved anyways.