URI parser - Githubissues

iotaledger / entangled

enTangle'd is an amalgamation of all things Tangle

Apache License 2.0

113 stars 66 forks source link

URI parser #91

Open thibault-martinez opened 5 years ago

thibault-martinez commented 5 years ago

In #82, I provided a very simple URI parser to parse neighbours URI like tcp://8.8.8.8:4242 or udp://8.8.8.8:4242

It is working and sufficient for neighbours but maybe we'll run into more use cases later needing a more complex URI parser.

We can then

find and use an existing complete URI parser
improve this one as and when we need it

howjmay commented 5 years ago

I want to solve this issue. What is the other use cases the URI parser will face in the future.

thibault-martinez commented 5 years ago

Hi @HowJMay, sorry for the late answer. A pretty obvious evolution of this URI parser is that it doesn't handle IPV6 atm. https://tools.ietf.org/html/rfc2732 Tests are missing too.

howjmay commented 5 years ago

Thank you for explaining. I am going to work on it in teh recent days.