iotaledger / identity.rs

Implementation of the Decentralized Identity standards such as DID and Verifiable Credentials by W3C for the IOTA Tangle.
https://www.iota.org
Apache License 2.0
290 stars 83 forks source link

[Task] Investigate `bls12_381_plus` dependency type incompatibility #1380

Open eike-hass opened 1 month ago

eike-hass commented 1 month ago

Description

The 0.8.16 version of bls12_381_plus introduces changes to type conversion that may break builds due to conflicting implementations of From trait.

error[E0119]: conflicting implementations of trait `From<bls12_381_plus::scalar::Scalar>` for type `Issuer`
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/identity_credential-1.3.0/src/credential/issuer.rs:43:1
   |
43 | / impl<T> From<T> for Issuer
44 | | where
45 | |   T: Into<Url>,
   | |_______________^
   |
   = note: conflicting implementation in crate `bls12_381_plus`:
           - impl From<bls12_381_plus::scalar::Scalar> for <bls12_381_plus::scalar::Scalar as ark_ff::fields::prime::PrimeField>::BigInt;
Pinning this dependency to the previous version hotfixes build issues when used as an indirect dependency here (via [zkryptium](https://crates.io/crates/zkryptium)).

Version should be able to opened up in the future. Pin implemented in #1278

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.