Closed frederikrothenberger closed 2 weeks ago
This PR introduces a feature custom_alg to identity_jose (disabled by default) that allows it to process JWS with custom alg values.
custom_alg
identity_jose
alg
Switching on custom_alg makes quite a few changes to JwsAlgorithm:
JwsAlgorithm
Copy
name()
String
&'static str
ALL
Fixes issue #1406.
Add an x to the boxes that are relevant to your changes.
x
Added a new integration test to identity_jose that exercises the functionality.
Note: requires CI changes to be run with cargo test --test custom_alg --features="custom_alg"
cargo test --test custom_alg --features="custom_alg"
@itsyaasir, @eike-hass: The change using a feature flag seems to be quite reasonable. What do you think?
Thanks for this @frederikrothenberger
This PR introduces a feature
custom_alg
toidentity_jose
(disabled by default) that allows it to process JWS with customalg
values.Switching on
custom_alg
makes quite a few changes toJwsAlgorithm
:Copy
name()
takes only a reference and returns aString
rather than&'static str
ALL
is removed as it is no longer possible to enumerate all variantsFixes issue #1406.
Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Added a new integration test to
identity_jose
that exercises the functionality.Note: requires CI changes to be run with
cargo test --test custom_alg --features="custom_alg"
Change checklist
Add an
x
to the boxes that are relevant to your changes.