iotaledger / identity.rs

Implementation of the Decentralized Identity standards such as DID and Verifiable Credentials by W3C for the IOTA Tangle.
https://www.iota.org
Apache License 2.0
299 stars 85 forks source link

Add support for custom JWS algorithms #1410

Closed frederikrothenberger closed 2 weeks ago

frederikrothenberger commented 3 weeks ago

This PR introduces a feature custom_alg to identity_jose (disabled by default) that allows it to process JWS with custom alg values.

Switching on custom_alg makes quite a few changes to JwsAlgorithm:

Fixes issue #1406.

Type of change

Add an x to the boxes that are relevant to your changes.

How the change has been tested

Added a new integration test to identity_jose that exercises the functionality.

Note: requires CI changes to be run with cargo test --test custom_alg --features="custom_alg"

Change checklist

Add an x to the boxes that are relevant to your changes.

frederikrothenberger commented 3 weeks ago

@itsyaasir, @eike-hass: The change using a feature flag seems to be quite reasonable. What do you think?

itsyaasir commented 2 weeks ago

Thanks for this @frederikrothenberger