search

iotaledger / inx-chronicle

IOTA permanode implemented using the IOTA Node Extension (INX) interface.
Apache License 2.0
14 stars 13 forks source link

Specify Hornet net config supplied by .env #1249

Closed trungtt198x closed 1 year ago

trungtt198x commented 1 year ago

Add the ability to specify Hornet net config JSON file that is supplied by the .env. This is to avoid direct editing the file docker\docker-compose.yml. So, in the .env, a new param HORNET_CONFIG_PATH is introduced.

trungtt198x commented 1 year ago

I think we also need to add the variable to the example .env

EDIT: I guess there is no example file, so maybe just add it to the README section.

I added a template file .env.template that should be OK

DaughterOfMars commented 1 year ago

Can you add it to the README as well?

trungtt198x commented 1 year ago

Can you add it to the README as well?

added

DaughterOfMars commented 1 year ago

Oh, you need to sign your commits, please.

trungtt198x commented 1 year ago

Oh, you need to sign your commits, please.

what do you mean by sign the commits ??

DaughterOfMars commented 1 year ago

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

This repo requires all commits to be signed.

trungtt198x commented 1 year ago

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

This repo requires all commits to be signed.

Can I still sign the commits that are already pushed? I realize that I use 2 different github accounts !! If I use the github account that is same as the one creating the PR, then do I still need to sign.

Maybe, I should close this PR and then open another PR with only 1 github account for commit?