search

iotaledger / inx-tendercoo

INX-Tendercoo enables a committee of validators to operate as a distributed Coordinator using Tendermint Core BFT consensus.
Apache License 2.0
1 stars 0 forks source link

Fix: False "peer proposed an invalid parent" log entries #58

Closed Wollac closed 1 year ago

Wollac commented 1 year ago

Coordinator.processParent gets called when a parent proposed by a validator becomes solid. Here, we check its validity before issuing a Proof. This PR clears all registered callbacks as soon as enough parents have been proven and the parents have been fixed in the milestone essence. Previously, the clear happened much later after the milestone was already signed. This lead to race conditions where Coordinator.processParent was called after the parents had already been fixed.